Add support for aarch64-unknown-linux-pauthtest#755
Draft
jchlanda wants to merge 1 commit intorust-lang:masterfrom
Draft
Add support for aarch64-unknown-linux-pauthtest#755jchlanda wants to merge 1 commit intorust-lang:masterfrom
aarch64-unknown-linux-pauthtest#755jchlanda wants to merge 1 commit intorust-lang:masterfrom
Conversation
This PR adds support for `aarch64-unknown-linux-pauthtest`, a target that enables Pointer Authentication Code (PAC) support in Rust on AArch64 ELF based Linux systems using a pauthtest ABI (provided by LLVM) and pauthtest-enabled sysroot with custom musl, serving as a reference libc implementation.
bjorn3
reviewed
Apr 20, 2026
| // as uw::_Unwind_FindEnclosingFunction creates a new context so | ||
| // the SP used for signing here would belong to a different frame | ||
| // that the one used for auth-resign. Hence return a raw value. | ||
| self.ip() |
Member
There was a problem hiding this comment.
Why is ip not signed? It is directly the result of _Unwind_GetIP. It should be possible to pass that to _Unwind_FindEnclosingFunction. How else would you even be able to use _Unwind_FindEnclosingFunction otherwise?
bjorn3
reviewed
Apr 20, 2026
| // clause, and if this is fixed that test in theory can be run on macOS! | ||
| if cfg!(target_vendor = "apple") { | ||
| self.ip() | ||
| } else if cfg!(target_env = "pauthtest") { |
Member
There was a problem hiding this comment.
Should this not check for the respective target feature being enabled? Not every target with pointer authentication enabled will use that target env, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
aarch64-unknown-linux-pauthtest, a target that enables Pointer Authentication Code (PAC) support in Rust on AArch64 ELF based Linux systems using a pauthtest ABI (provided by LLVM) and pauthtest-enabled sysroot with custom musl, serving as a reference libc implementation.Please consult a rust-lang PR for the details on the target: TODO JKB Add link